Update get_location documentation and add caching
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfardet
added
documentation
|
Failure in 3.10 seems unrelated to the PR (call to get_geodata which has not been modified)... not sure whether it's worth restarting the test... @hadrilec I'll let you decide on that. |
|
I restarted the one which failed, it looks fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168 and adds caching to
_get_location_openstreetmap.I also cleaned up some imports and bare
exceptclauses.Finally, I moved the
get_locationdirectly as a method and removed its former file.You can ignore the two test files, I just checked them and my editor autoremoves trailing whitespaces.